This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fca8cb47d831: Ftp ioslave: fix 4 character time
interpreted as year (authored by linagkar, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25966?v
ngraham added a comment.
Thanks, you did great! Nice patch too. May it be the first of many. :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25966
To: linagkar, dfaure, #frameworks, sitter, feverfew
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
linagkar added a comment.
My email address is linus.kard...@gmail.com
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25966
To: linagkar, dfaure, #frameworks, sitter, feverfew
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
ngraham added a comment.
I learned recently that you can find out if someone has commit rights by
doing a find on https://websvn.kde.org/trunk/kde-common/accounts?view=markup.
Looks like no in this case. @linagkar, can we have your email address so we
can land the patch with correct auth
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Looks correct (given the if() further down, not visible in this context-less
patch).
Do you have commit access, or do you need someone to land this?
[I wish this parsing code was i
ngraham added reviewers: dfaure, Frameworks, sitter, feverfew.
ngraham added a comment.
Thanks for the patch!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25966
To: linagkar, dfaure, #frameworks, sitter, feverfew
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, mic
linagkar created this revision.
linagkar added a project: Frameworks.
linagkar requested review of this revision.
REVISION SUMMARY
Previously, the code checked for years by checking for length 4. However this
resulted in dates with single digit hours, e.g. 9:37, being interpreted as
years. Thu
