D25937: pic: Fix Invalid-enum-value undefined behaviour

2019-12-14 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25937 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25937: pic: Fix Invalid-enum-value undefined behaviour

2019-12-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Interesting case of "type safety being worse" ;-) REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D25937 To: aacid, dfaure Cc: dfaure, securi

D25937: pic: Fix Invalid-enum-value undefined behaviour

2019-12-14 Thread Albert Astals Cid
aacid added a subscriber: security-team. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25937 To: aacid Cc: security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25937: pic: Fix Invalid-enum-value undefined behaviour

2019-12-12 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Instead of directly casting the quint8 to PicChannelEncoding we just store the quint8 and compare it to the possible PicC