This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.
Closed by commit R304:197f257cb9b6: Ensure the dialog title is correct with an
uninitialised engine (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
htt
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Kaboom
REPOSITORY
R304 KNewStuff
BRANCH
ensure-dialog-title-with-uninitialised-engine (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25849
To: leinir, #framew
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> ngraham wrote in Dialog.qml:55
> For readability's sake and to avoid nested `i18n()` calls which would cause
> string puzzles, I would do it like this:
>
> title: component.downloadNewWhat.length === 0 ?
leinir updated this revision to Diff 71234.
leinir added a comment.
- Less string puzzles are better
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25849?vs=71198&id=71234
BRANCH
ensure-dialog-title-with-uninitialised-engine (branched from master)
REV
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> Dialog.qml:55
> property string downloadNewWhat: engine.name
> -title: i18n("Download New %1", component.downloadNewWhat)
> +title: i18n("Downlo
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
Prior to this patch, when the engine was not correctly initialised,
it would cause the dialog title to be Download New %
leinir added reviewers: Frameworks, KNewStuff, ngraham.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D25849
To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
