This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R293:76b81a614f10: Correctly report if baloo_file is
unavailable (authored by davidedmundson).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://p
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.
Thx
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25789
To: davidedmundson, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, hurikhan77, lots
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> bruns wrote in monitor.cpp:67
> The watcher should be installed unconditionally, and first.
>
> Checking state first and the instaling the watcher is racy.
Good catch. Done
REPOSITORY
R29
davidedmundson updated this revision to Diff 71771.
davidedmundson added a comment.
swap order to fix potential race
change i18n
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25789?vs=71024&id=71771
BRANCH
master
REVISION DETAIL
https://phabricator.k
bruns added inline comments.
INLINE COMMENTS
> monitor.cpp:67
> m_balooRunning = false;
> QDBusServiceWatcher* balooWatcher = new
> QDBusServiceWatcher(m_scheduler->service(),
> m_bus,
The watcher should be insta
ngraham added a comment.
Maybe instead of "Unavailable", it could say "Not Running"?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D25789
To: davidedmundson
Cc: ngraham, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashap
davidedmundson created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Add a new state. Watch for service unregistration as well as
registration.
REPOSITORY
R29
