mlaurent added inline comments.
INLINE COMMENTS
> khistorycombobox.cpp:435
> +
> +for (const QString item : items) {
> +if (item.isEmpty()) {
Missing & here no ?
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D25754
To: nicolasfella, #frameworks, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems
(authored by nicolasfella).
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25754?vs=70926&id=71054
REVISIO
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R284 KCompletion
BRANCH
refa
REVISION DETAIL
https://phabricator.kde.org/D25754
To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Use range-based for instead of iterators
Apply return-early idiom
