ervin added a comment.
notifySignal would definitely make sense on the signalling items indeed. It's
kind of the information we're trying to guess here.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D25746
To: apol, #frameworks, tcanabrava, ervin
Cc: kde-frame
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:12b3c947a8a4: Adapt to change in KConfigCompiler
(authored by apol).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25746?vs=70912&id=70921
REVISION DETAIL
apol added a comment.
I'll land this for now because the alternative is to have this not working.
Maybe it would make sense to include a KConfigSkeletonItem::propertyName
property? Or even a KConfigSkeletonItem::notifySignal(KConfigSkeleton*)?
Then here we could just consume the info
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
My gut feeling would be to keep the item and the property names in sync
unlike now... but this is a good fix as well indeed.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
apol created this revision.
apol added reviewers: Frameworks, tcanabrava, ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Properties need to start with lower-case letters, otherwise QML won't
u
