D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Nathaniel Graham
ngraham added a comment. Good idea, done in 912ec731b8bd9eca12ae21920c81bcddfb46622b . REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: ahmadsamir, el

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Ahmad Samir
ahmadsamir added a comment. In D25720#573926 , @elvisangelaccio wrote: > In D25720#572291 , @ngraham wrote: > > > Though Dolphin seems to have some kind of local hack to make Shift+delete work for

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-09 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. All right. Thanks for the history! REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: elvisangelaccio, aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-08 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D25720#572291 , @ngraham wrote: > Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. Yes it's messy but

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-05 Thread Albert Astals Cid
aacid added a comment. > Trying to assign anything to Shift+Delete shows the "conflicting shortcuts" error dialog. But that's fine, no? I mean this is the user assigning a shortcut that already exists, not any different than the user trying to assign Ctrl+C somewhere. If he doesn't

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-05 Thread Nathaniel Graham
ngraham added a comment. In D25720#572326 , @aacid wrote: > Apps that need both should be aware of it and remove the secondary Cut shortcut. > > Or if you want to be mega fancy you can make kactioncollection (or something in xmlgui) do that

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Albert Astals Cid
aacid added a comment. Apps that need both should be aware of it and remove the secondary Cut shortcut. Or if you want to be mega fancy you can make kactioncollection (or something in xmlgui) do that REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ng

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Alexander Potashev
aspotashev added a comment. In D25720#572291 , @ngraham wrote: > Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. I don't know the intern

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Nathaniel Graham
ngraham added a comment. Though Dolphin seems to have some kind of local hack to make Shift+delete work for file deletion. But it doesn't work for Cut. It's all pretty messy. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: a

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Nathaniel Graham
ngraham added a comment. For example Dolphin REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Alexander Potashev
aspotashev added a comment. What are the applications where both actions are used and thus one may notice this conflict? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Nathaniel Graham
ngraham added a comment. We have to change //something//, or else there's conflict that breaks both of them in apps where both actions are implemented. Changing anything breaks someone's workflow; the question is whose we can live with breaking. REPOSITORY R237 KConfig REVISION DETAIL h

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Ben Cooksley
bcooksley added a comment. Shift+Delete is a widely known shortcut combination for "Delete File Immediately, do not send to the Recycle Bin" REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: bcooksley, davidedmundson, aacid, a

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Nathaniel Graham
ngraham added a comment. Ack. So shall we change the shortcut for delete file then? Any suggestions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: davidedmundson, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michael

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread David Edmundson
davidedmundson added a comment. It's not just old timers, it's an accessibility thing for people who are left handed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: davidedmundson, aacid, apol, kde-frameworks-devel, LeGast0

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-04 Thread Albert Astals Cid
aacid added a comment. Shift + Delete for cut is the old timer Unix cut shortcut, you're going to piss lots of people off if you remove that shortcut from every single application just because it causes a conflict in applications that do file management REPOSITORY R237 KConfig REVISION D

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-03 Thread Aleix Pol Gonzalez
apol added a comment. +1 it doesn't seem to me that shift+delete is used elsewhere. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

2019-12-03 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY [⇧] + [Delete] is bound to both Cut and Delete File, meaning that it can't b