D25626: Fix EcmGenerateExportHeader tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R240:bfdcec82d926: Fix EcmGenerateExportHeader tests on Windows (authored by davidre). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25626?vs=70610&id=70615

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre added a comment. In D25626#569714 , @kossebau wrote: > Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the da

D25626: Fix EcmGenerateExportHeader tests on Windows

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre retitled this revision from "Fix EcmGenerateExportHeader tests on windows" to "Fix EcmGenerateExportHeader tests on Windows". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel,

D25626: Fix EcmGenerateExportHeader tests on windows

davidre added reviewers: kossebau, Windows, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on windows

davidre created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY -we errors on warning . C4996 warns on deprecated declarations. TEST PLAN Tests