D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-30 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-30 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-30 Thread Kevin Ottens
ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, maybe give some times to others to chip in. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin Cc: kde-frameworks-devel, e

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-29 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The generated classes of kconfig_compiler take a KSharedConfig::Ptr by value, one possibility would be to make them const