cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks good to me!
Thanks!
REPOSITORY
R216 Syntax Highlighting
BRANCH
ps-escape (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax, dhaumann, cu
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3d28d32776c9: Add string escape characters to PowerShell
syntax. (authored by zrax, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
zrax updated this revision to Diff 69011.
zrax added a comment.
- Add test case for new escape sequences to powershell autotest
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25054?vs=69010&id=69011
BRANCH
ps-escape (branched from master)
RE
dhaumann added a comment.
Looks good to me.
Btw, you posted several patches over the last two years. You could also apply
for a KDE contributor account and push yourself, if you want.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax, d
zrax updated this revision to Diff 69010.
zrax added a comment.
- Add test case for new escape sequences to powershell autotest
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25054?vs=68996&id=69010
BRANCH
ps-escape (branched from master)
RE
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I can push it for you.
But I think it would be a good idea to have an unit test extended with the
new supported syntax parts.
Could you add that?
REPOSITORY
R216 Syntax
zrax added a comment.
I do not have a KDE developer account, so I cannot land the change myself
presently.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ps-escape (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Please commit.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ps-escape (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax, dhaumann
Cc: dhaumann, kw
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D25054
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.
REVISION SUMMARY
Powershell uses the syntax ` or `u{hex} as escape sequences within
double-quoted strings. This adds highl
12 matches
Mail list logo
