aacid abandoned this revision.
aacid added a comment.
I don't know either. Let's not micro optimize without need and knowledge
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D24936
To: aacid
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure added a comment.
Should this be in if (folder->unpackCRCDefined) like the check for
unpackSize? Disclaimer: I don't know this code.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D24936
To: aacid
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24936
AFFECTED FILES
src/k7zip.cpp
To: aacid
Cc