D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham added a reviewer: nicolasfella. ngraham added a comment. Let's continue in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/57. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To

D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: ngraham, #plasma, mart, #vdg, davidedmundson, nicolasfella Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, cblack, michaelh, bruns

D24895: [RFC] Drop implicit size from PC buttons

2020-03-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes as per my comments above REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasf

D24895: [RFC] Drop implicit size from PC buttons

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, cblack, GB_2, michaelh, bruns

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread David Edmundson
davidedmundson added a comment. Having had a play, setting implicitWidth to unit.gridUnit * 1.6 and keeping height as-is, makes the most things pass. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc:

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread David Edmundson
davidedmundson added a comment. Please run plasma tests/components/button.qml and tests/components/button3.qml it explains all goals visually (and shows some other PC3 issues) This patch fails "button with or without icon and textfield" should all have the same height. I understa

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Kai Uwe Broulik
broulik added a comment. Perhaps only when it has no text so icon-only can become rightfully square? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: broulik, ngraham, kde-frameworks-devel, mart, LeGas

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 68629. nicolasfella added a comment. - Actually remove REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24895?vs=68628&id=68629 BRANCH mo REVISION DETAIL https://phabricator.kde.org/D24895 A

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. Compatibility with the wide style in PC1 I think? I've always thought this was kind of weird as well. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #v

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It makes buttons in apps using plasma as a QQC2 style weirdly wide

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns