D24742: Make non-ignorable SSL errors explicit

2019-10-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8dc567852b26: Make non-ignorable SSL errors explicit (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68289&id=69071 REVISION DETAIL ht

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a comment. Anyone? This blocks the subsequent SSL error patches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-25 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-19 Thread Volker Krause
vkrause updated this revision to Diff 68289. vkrause added a comment. Rebase on recent changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68248&id=68289 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES src/cor

D24742: Make non-ignorable SSL errors explicit

2019-10-18 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-18 Thread Volker Krause
vkrause updated this revision to Diff 68248. vkrause added a comment. Fix return value. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68168&id=68248 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES src/core/ksslce

D24742: Make non-ignorable SSL errors explicit

2019-10-17 Thread Aleix Pol Gonzalez
apol added a comment. LGTM otherwise INLINE COMMENTS > ksslcertificatemanager.cpp:537 > +}); > return {}; > } `return ret; ` ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D24742: Make non-ignorable SSL errors explicit

2019-10-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far this is done implicitly in KSSLD by not being able to persist these error codes in its config file. This howeve