broulik accepted this revision.
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24716
To: davidedmundson, #plasma, ervin, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:aea58fcca359: Fix memory leak of
KQuickAddons::ConfigModule objects (authored by davidedmundson).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24716?vs=68113&id=
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
Looks good to me, I'll accept it but better wait a bit in case others want to
chip in.
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24716
To: d
davidedmundson marked 2 inline comments as done.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D24716
To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 68113.
davidedmundson edited the summary of this revision.
davidedmundson removed a reviewer: ervin.
davidedmundson removed a subscriber: ervin.
davidedmundson added a comment.
Use unique_ptr
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
h
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmoduleloader.cpp:101
> } else {
> KQuickAddons::ConfigModule *cm =
> factory->create(nullptr, args2);
> if (!cm
davidedmundson updated this revision to Diff 68096.
davidedmundson added a comment.
Slightly refactor so the teardown order deletes the QML content and then
deletes the parent window which is a bit more logical.
Now kscreen KCM doesn't crash even with the extra prompts
REPOSITORY
R29
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
When we create a KQuickAddons::ConfigModule in the factory we di
