apol added a comment.
👍 sorry about slow reviews. The patch looks good.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D24671
To: kossebau, #frameworks, #plasma, mart, apol
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:d03f2d7114c4: Use ECMGenerateExportHeader to manage
deprecated API better (authored by kossebau).
REPOSITORY
R290 KP
kossebau added a comment.
Reviewed myself once more and will be pushing now, given this is fairly
straightforward after all, so the KF_* flags can be enabled next.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D24671
To: kossebau, #frameworks, #plasma, mart, apol
mlaurent added a comment.
Seems ok for me +1
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D24671
To: kossebau, #frameworks, #plasma, mart, apol
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
kossebau added a comment.
@apol Hi. Any chance you can give this a review soon, given this is almost
the last one remaining before the complete of all (affected) KF modules to
ECMGenerateExportHeader is done, and we can enable the respective KF_* macros?
REPOSITORY
R290 KPackage
REVISION
kossebau updated this revision to Diff 67991.
kossebau added a comment.
keep the current filename of the export header file
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24671?vs=67990&id=67991
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https
kossebau added a comment.
Given all the `KPACKAGE_*` macros are public, they should be consistently in
the namespace, so for that purpose I also simply changed the BASE_NAME of the
export macros.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D24671
To: kossebau,
kossebau created this revision.
kossebau added reviewers: Frameworks, Plasma, mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Allows
- projects linking to KPackage to hide deprecate
