This revision was automatically updated to reflect the committed changes.
Closed by commit R159:1ea2058a09c9: Windows MSVC compile fix (authored by
cullmann).
REPOSITORY
R159 KActivities Statistics
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24620?vs=67869&id=68393
REVISION DETAI
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Imo we should simply try: We have another two weeks for testing.
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D24620
To: cullmann, #frameworks
cullmann added a comment.
Can I just push that? Then we no longer need to patch just this one framework
for Windows.
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D24620
To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n
cullmann added a comment.
Ok to push that? Would avoid the last patch in craft to build frameworks.
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D24620
To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
cullmann updated this revision to Diff 67869.
cullmann added a comment.
Missed to add file with proper compiler guard :/
REPOSITORY
R159 KActivities Statistics
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24620?vs=67867&id=67869
REVISION DETAIL
https://phabricator.kde.org/D24
cullmann created this revision.
cullmann added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.
REVISION SUMMARY
This patch is since "long" in craft blueprints, can we merge that?
TEST PLAN
