D24395: Add some std::move in setter functions

2019-10-07 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R235:1c8d9beb720f: Add some std::move in setter functions (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24395?vs=67272&id=67469#toc REPOSITORY R235 Attica CHANGES SINCE LAS

D24395: Add some std::move in setter functions

2019-10-03 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten when we can, in fact, fix it properly, that'd be great :) REPOSITORY R235 Attica BRANCH master REVISION DET

D24395: Add some std::move in setter functions

2019-10-03 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY typically we pass the param as const &, but here we forgot, we can fix that problem by adding an std::move and have a very