D24025: Don't use KCrash on Android

nicolasfella abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. see Volker's comment REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast0

D24025: Don't use KCrash on Android

vkrause added a comment. In D24025#533428 , @apol wrote: > In D24025#533418 , @vkrause wrote: > > > I think the line between dummy and #ifdef is in the commit message: if we don't want something on

D24025: Don't use KCrash on Android

apol added a comment. In D24025#533418 , @vkrause wrote: > I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go fo

D24025: Don't use KCrash on Android

vkrause added a comment. I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd say,

D24025: Don't use KCrash on Android

broulik added a comment. I surely don't want to have apps start to #ifdef a ton of stuff out, which works against the nature of Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n,

D24025: Don't use KCrash on Android

nicolasfella added a comment. In D24025#533310 , @broulik wrote: > Can't we make KCrash just no-op on Android? It pretty much is. The problem I'm fixing only started to arise when I blacklisted it on the Android builds because it's 1) use

D24025: Don't use KCrash on Android

apol added a comment. Why not? it could be useful. The alternative is darkness over what happened there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

broulik added a comment. Can't we make KCrash just no-op on Android? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We don't want/have KCrash on Android, so diable the pieces there TEST