D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R294:797763d4b4d2: KBookmark: improve addBookmark apidox (authored by elvisangelaccio). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23955?vs=66108&id=66148 REVISI

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D23955#531647 , @dfaure wrote: > OK (why does this matter to the user of the class, though?) See D23706 , dolphin is going to need regex-based matches on the placesmo

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK (why does this matter to the user of the class, though?) REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D23955 To: elvisangelaccio, dfaure C

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Clarify that the URL will be stored in its toString(QUrl::Full