D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-13 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R311:ef7ec39e9be1: Port from KIconLoader to QIcon::fromTheme (authored by vkrause). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23899?vs=65985&id=65990 REVISION DETA

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-13 Thread David Faure
dfaure added a comment. You can land it as soon as the underlying API changes are in. KF5 is treated like a single repo in terms of inter-framework dependencies. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfau

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-13 Thread David Faure
dfaure accepted this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-13 Thread Volker Krause
vkrause updated this revision to Diff 65985. vkrause added a comment. Adapt to widgetaddons changes. When can this land considering it depends on brand new API in another framework? REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23899?vs=65920&id=65985

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-13 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Beautiful :-) REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-12 Thread Volker Krause
vkrause updated this revision to Diff 65920. vkrause added a comment. Make use of D23904 . REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23899?vs=65906&id=65920 BRANCH master REVISION DETAIL https://phabricator.kde

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-12 Thread Volker Krause
vkrause added a comment. Yep, makes sense. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-12 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:636 > kpd->setWindowTitle(i18n("KDE Wallet Service")); > -kpd->setPixmap( > - > K

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-12 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

2019-09-12 Thread Volker Krause
vkrause created this revision. vkrause added reviewers: davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/