D23802: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R309:ce11545c51ec: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67803&id=

D23802: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. REPOSITORY R309 KService BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67803. kossebau marked an inline comment as done. kossebau added a comment. add missing #if/#endif for KToolInvocation::invokeBrowser REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67731&id=67803 BRANCH us

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ktoolinvocation.h:152 > No #if for this one? I cannot remember this was left out on purpose, so far assume I was just confused by the existing if/endif spanning multiple methods, and mis

D23802: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > ktoolinvocation.h:152 > */ > -KSERVICE_DEPRECATED static void invokeBrowser(const QString &url, > +KSERVICE_DEPRECATED_VERSION(5, 0, "Use QDesktopServices::openUrl(const > QUrl&)") > +static void invokeBrowser(const QString &url,

D23802: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67731. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67655&id=6773

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67655. kossebau added a comment. tests no longer need to unset KSERVICE_DEPRECATED REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67222&id=67655 BRANCH useECMGenerateExportHeader REVISION DETAIL https:/

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802