This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3ff7f78ebcb7: gcc naming conflict (authored by mickaelbo,
committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23484?vs=64727&id=64757
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
ok, thanks
REVISION DETAIL
https://phabricator.kde.org/D23484
To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGas
mickaelbo updated this revision to Diff 64727.
mickaelbo added a comment.
It makes sense.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23484?vs=64719&id=64727
REVISION DETAIL
https://phabricator.kde.org/D23484
AFFECTED FILES
src/indexer/katehighlightingindexer.cpp
To: mickae
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I would prefer that we just rename the vars.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23484
To: mickaelbo, #framework_syntax_highl
mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.
REVISION SUMMARY
With gcc 7.4.0 (and maybe some other versions), "m
