D23313: improve code in Snore backend

2019-08-21 Thread Piyush Aggarwal
brute4s99 abandoned this revision. brute4s99 added a comment. in that case I should rather leave this diff. I agree this would be messy for the history. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23313 To: brute4s99, broulik Cc: kde-frameworks-devel, LeG

D23313: improve code in Snore backend

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better INLINE COMMENTS > notifybysnore.cpp:141 > + > +void NotifyBySnore::notify(KNotification* notification, KNotifyConfig > *config) > +{ The pr

D23313: improve code in Snore backend

2019-08-20 Thread Piyush Aggarwal
brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D