D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. Sorry for breaking the build :/ @kossebau - thanks for fixing it so quickly! I think your fix looks fine :D REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik, mpyne Cc: kossebau, bcooksley, mpy

D23205: [KProcessList] Optimize KProcessList::processInfo

kossebau added a comment. I pushed a quick fix to unbreak the build as bfdc20ed7c6fc1397ba66edd07f86c84d380e291 You might want to inspect it to add that optimization code for the procstat as well, if possible (no i

D23205: [KProcessList] Optimize KProcessList::processInfo

bcooksley added a comment. This broke the build on FreeBSD - See https://build.kde.org/view/Failing/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/console REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundso

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik, mpyne Cc: mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. I've reviewed the patch and it's good, you've addressed the issues that were noted by Aleix already, so please commit and we can address anything that might pop up as it happens. REPOSITORY

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. @davidedmundson - ping ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. @davidedmundson ping :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. @davidedmundson - ping :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas updated this revision to Diff 64914. hallas added a comment. Add bug reference REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23205?vs=64913&id=64914 BRANCH optimize_kprocesslist_processinfo REVISION DETAIL https://phabricator.kde.org/D2320

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas updated this revision to Diff 64913. hallas marked an inline comment as done. hallas added a comment. Fixed review comments, rebased. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23205?vs=63873&id=64913 BRANCH optimize_kprocesslist_processin

D23205: [KProcessList] Optimize KProcessList::processInfo

apol added a comment. patch looks good overall. INLINE COMMENTS > kprocesslist_unix.cpp:157 > const QStringList procIds = procDir.entryList(); > if (procIds.isEmpty()) > return rc; checking if it's empty is unnecessary. > kprocesslist_unix.cpp:171 > +KProcessInfo proc

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas created this revision. hallas added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. hallas requested review of this revision. REVISION SUMMARY Optimize KProcessList::processInfo on unix so that it doesn't iterate over all processes and then filter the list to the