D22864: use zero-based coordinate system on the plot

2019-08-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R296:6292aa057a38: use zero-based coordinate system on the plot (authored by miklosm, committed by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22864?vs

D22864: use zero-based coordinate system on the plot

2019-08-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm, #plasma, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22864: use zero-based coordinate system on the plot

2019-08-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm, #plasma, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22864: use zero-based coordinate system on the plot

2019-08-02 Thread Nathaniel Graham
ngraham added reviewers: Plasma, davidedmundson. ngraham added a comment. Got it, thanks! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm, #plasma, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22864: use zero-based coordinate system on the plot

2019-08-02 Thread Miklós Máté
miklosm added a comment. In D22864#505559 , @ngraham wrote: > Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section. The problem this is fixing: F7141055: network moni

D22864: use zero-based coordinate system on the plot

2019-08-01 Thread Nathaniel Graham
ngraham added a comment. Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm Cc: ngraham, kde-frameworks-devel, LeGast00n, sbe

D22864: use zero-based coordinate system on the plot

2019-07-31 Thread Miklós Máté
miklosm created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. miklosm requested review of this revision. REVISION SUMMARY This patch also supports negative values, but the plot drawing code can't properly handle them. REPOSITORY R296 KDec