This revision was automatically updated to reflect the committed changes.
Closed by commit R296:e634bda6331c: introduce FallbackTapHandler (authored by
mart).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22860?vs=62891&id=62894
REVISION DETAIL
https:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
phab/fallbacktaphandler
REVISION DETAIL
https://phabricator.kde.org/D22860
To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbe
mart updated this revision to Diff 62891.
mart added a comment.
- get completely rid of acceptedMouse§Buttons
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22860?vs=62890&id=62891
BRANCH
phab/fallbacktaphandler
REVISION DETAIL
https://phabricato
davidedmundson added inline comments.
INLINE COMMENTS
> fallbacktaphandler.cpp:50
> +{
> +setAcceptedMouseButtons(buttons);
> +emit acceptedButtonsChanged();
m_buttons = buttons
or change the getter for acceptedButtons to call
QQuickItem::acceptedMouseButtons
REPOSITORY
R296 KDeclar
mart marked 3 inline comments as done.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D22860
To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,
ngraham, bruns
mart updated this revision to Diff 62890.
mart added a comment.
- adress comments
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22860?vs=62868&id=62890
BRANCH
phab/fallbacktaphandler
REVISION DETAIL
https://phabricator.kde.org/D22860
AFFECTED F
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fallbacktaphandler.cpp:71
> +m_mouseDownItem.clear();
> +m_mouseDownPos = QPointF();
> +
You're clearing before doing the tap
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.
REVISION SUMMARY
This element is intended to be used as "click on empty areas
to dismiss" use case.
a MouseA
