volkov abandoned this revision.
volkov added a comment.
Moved to https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/7
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D22737
To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack,
volkov updated this revision to Diff 62536.
volkov added a comment.
fixed
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22737?vs=62531&id=62536
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22737
AFFECTED FILES
src/platforms/xcb
volkov added inline comments.
INLINE COMMENTS
> apol wrote in kwindowsystem.cpp:75
> I don't think that it makes sense to multiply topLeft by dpr, since dpr is
> local to the screen you're treating.
>
> How have you tested this?
Only on a single screen. Thanks for notice.
REPOSITORY
R278 KW
apol added inline comments.
INLINE COMMENTS
> kwindowsystem.cpp:75
> +const qreal dpr = screen->devicePixelRatio();
> +region += QRect(geometry.topLeft() * dpr, geometry.size() * dpr);
> }
I don't think that it makes sense to multiply topLeft by dpr, since dpr is
volkov added a reviewer: Frameworks.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D22737
To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.
REVISION SUMMARY
In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL,
which requires screen's geometry in device pixe
