D22609: Add expanding spacers as a customization option for toolbars

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4357ef235ecb: Add expanding spacers as a customization option for toolbars (authored by felixernst, committed by ngraham). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde

D22609: Add expanding spacers as a customization option for toolbars

dfaure added a comment. Agreed. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure, ngraham Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22609: Add expanding spacers as a customization option for toolbars

ngraham accepted this revision. ngraham added a comment. I think we should make everything uppercase, and if the separators need visual differentiation, making them lowercase is kind of a hack. **However**, that change would need to be made in a separate patch because it affects more tha

D22609: Add expanding spacers as a customization option for toolbars

felixernst added a comment. I kept the names lowercase because I like the visible difference between lowercase separator/spacer and title case actions. I don't mind changing the names to title case though. Judge for yourself: F7109858: Screenshot_20190728_185837.png

D22609: Add expanding spacers as a customization option for toolbars

felixernst updated this revision to Diff 62687. felixernst marked an inline comment as done. felixernst added a comment. Rename to "expanding spacer", Cast to QToolBar instead Remove unrelated comments and documentation REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabri

D22609: Add expanding spacers as a customization option for toolbars

dfaure added a comment. OK, if you don't think there is a use case, let's leave fixed-width spacers aside for now. I was wondering abour the lowercase thing, too. It looks weird. Maybe Separator should become uppercase so they can both be? REPOSITORY R263 KXmlGui BRANCH master REV

D22609: Add expanding spacers as a customization option for toolbars

felixernst retitled this revision from "Add spacers as a customization option for toolbars" to "Add expanding spacers as a customization option for toolbars". REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure Cc: ngraham, #vdg