This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:969e01dc8d60: [KProcessList] Split command line and
process name (authored by davidedmundson).
REPOSITORY
R244 KCore
broulik added a comment.
Should we ship this now? After frameworks tagging I guess.
Also, can you add a `CHANGELOG: KProcessInfo::name() now returns only the
name of the executable. For the full command line use KProcessInfo::command()`
so it shows up nicely in the release announcement chan
davidedmundson added a comment.
> So now name() will often return an empty string?
That's certainly not the intention.
The system is:
Firstly we do the fallback. Reading from /proc/N/state . Though this is
rubbish and truncates things.
Both name and command are set to this.
apol added a comment.
So now name() will often return an empty string?
INLINE COMMENTS
> kprocesslist_unix.cpp:142
> +int processNameStart = cmd.lastIndexOf('/', zeroIndex);
> +if (processNameStart == -1) {
> +processNameStart = 0;
if it's
davidedmundson updated this revision to Diff 61784.
davidedmundson added a comment.
Swap member order
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22471?vs=61783&id=61784
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22471
AFFECTED
broulik added a comment.
+1
INLINE COMMENTS
> kprocesslist_p.h:46
> qint64 pid;
> +QString command;
> QString name;
Order name before since that's how the methods are ordered
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D22471
To: davidedmundso
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Currently KProcessList had a method called "name" which confusingly
returns the entire command line.
