turbov added a comment.
I would say all commands w/ `COMMAND` named parameter need that. Also,
`add_custrom_target` and `execute_process`...
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22095
To: smokris, #framework_syntax_highlighting, cullmann
Cc: t
smokris updated this revision to Diff 60669.
smokris added a comment.
Updated cmake.xml + cmake.xml.tpl version number.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22095?vs=60662&id=60669
REVISION DETAIL
https://phabricator.kde.org/D22095
cullmann added a comment.
Ah, I missed: the version should be updated.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22095
To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortim
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me. Thanks!
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22095
To: smokris, #framework_syntax_highlighting, cullmann
Cc: cul
smokris added a reviewer: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22095
To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson,
michaelh, genethomas, ng
smokris created this revision.
smokris added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.
REVISION SUMMARY
The CMake syntax highlighter was getting conf
