This revision was automatically updated to reflect the committed changes.
Closed by commit R495:a207a669815f: Don't show error message if sharing is
cancelled by the user (authored by nicolasfella).
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21989?
apol accepted this revision.
REPOSITORY
R495 Purpose Library
BRANCH
noerror
REVISION DETAIL
https://phabricator.kde.org/D21989
To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R495 Purpose Library
BRANCH
noerror
REVISION DETAIL
https://phabricator.kde.org/D21989
To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
nicolasfella marked an inline comment as done.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D21989
To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 60321.
nicolasfella added a comment.
- use KIO::ERR_USER_CANCELED
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21989?vs=60317&id=60321
BRANCH
noerror
REVISION DETAIL
https://phabricator.kde.org/D219
broulik added inline comments.
INLINE COMMENTS
> sharefileitemaction.cpp:55
> +// error == 0 means no error, error == 1 means cancelled by the user
> +if (error <= 1) {
> if (output.contains(QLatin1String("url")))
If possible use `KIO::ERR_USER_CANCELED`, otherwise d
nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Cancelling a share is usually intentional and should not result i
