D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480777 , @poboiko wrote: > > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects. > > Yep, that's what I've suggested (if I understood you c

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

poboiko added a comment. > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects. Yep, that's what I've suggested (if I understood you correctly). I guess, we can put the trimming part right to `termList()`, it will furt

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480765 , @poboiko wrote: > Actually, there is an issue with that code right now, which I wanted to fix, but forgot. > The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed o

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7420bc056326: [TermGenerator] Use UTF-8 ByteArray for termList (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21839?vs=59896&id=59942 REVISION D

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

poboiko added a comment. Actually, there is an issue with that code right now, which I wanted to fix, but forgot. The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed on `QString` instead of `QByteArray` - unicode symbols inside term can consist of two

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21839 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov,

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY All users of TermGenerator::termList do not use QStrings bu