vonreth added inline comments.
INLINE COMMENTS
> database.cpp:49
> +// the macros without ifdef'ing these in place
> +#if defined _MSC_VER && !defined NVALGRIND
> +#define NVALGRIND 1
Id suggest to use Q_CC_MSVC but it looks ok
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:617e371d972f: Disable valgrind detection when compiling
with MSVC (authored by bruns).
REPOSITORY
R293 Baloo
CHANGE
bruns removed a reviewer: Baloo.
bruns added a subscriber: Baloo.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21599
To: bruns, #windows, bcooksley
Cc: #baloo, alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,
michaelh, astippich, spoorun, ngraham, bru
alexeymin accepted this revision as: Windows.
alexeymin added a comment.
This should work.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21599
To: bruns, #baloo, #windows, bcooksley
Cc: alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,
michaelh, ast
bruns created this revision.
bruns added reviewers: Baloo, Windows, bcooksley.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
MSVC chokes on the inline assembly, use the stub macros there instea
