jpoelen added a comment.
After reflection (:D), I think the constraint is weak, the creation of new
syntax is rare compared to the rest.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21586
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build
(authored by jpoelen).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21586?vs=59240&id=59421
REVIS
cullmann added a comment.
Perhaps we must go away from the implicit listing of the syntax files and
really just add them all to the CMakeLists.txt,
REPOSITORY
R216 Syntax Highlighting
BRANCH
ninja (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21586
To: jpoelen,
jpoelen updated this revision to Diff 59240.
jpoelen added a comment.
I am confused, the generation of index.katesyntax fails because the list
"variables" does not exist (there is no variable predefined in this context).
We may be in a situation where a change of branch does not recompile the
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Nice, I use ninja here, cool to have!
REPOSITORY
R216 Syntax Highlighting
BRANCH
ninja (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21586
To: jpoelen, #fr
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ninja (branched from mast