bcooksley added a comment.
This changes breaks the build on Windows/MSVC because 'valgrind.h' doesn't
support MSVC.
Can you please correct this / disable this check on Windows?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21581
To: bruns, #baloo, ngraham, astippi
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:446aeb07d922: Detect valgrind, avoid database removal
when using valgrind (authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21581?vs=59137&id=59139
ngraham accepted this revision.
ngraham added a comment.
Hah, wow
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21581
To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc: mgallien, kde-frameworks-devel, LeGast00n, domson, ashaposhnik
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Very nice. Thank you
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21581
To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc:
bruns updated this revision to Diff 59137.
bruns added a comment.
rebase
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21581?vs=59136&id=59137
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21581
AFFECTED FILES
src/engine/database.cpp
bruns edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21581
To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko, broulik.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
The mmap size supported by valgrind is set at valg
