This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes
(authored by jpoelen).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21508?vs=59150&id=59164
REVISIO
dhaumann accepted this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_jam (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21508
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh
jpoelen updated this revision to Diff 59150.
jpoelen added a comment.
- fix module
- remove hard coded color
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21508?vs=58930&id=59150
BRANCH
fix_jam (branched from master)
REVISION DETAIL
htt
jpoelen added a comment.
I left it because it goes well with dark or light themes, but I removed it.
Is the policy the same for bold, underlined and italic as for color? Because a
basic applied distinction between Comment and CommentTitle seems to me
preferable. I imagine not, but I would li
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
(the hard coded color was already there, therefore this doesn't block this
request)
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_jam (branched from master)
REVISION DETAIL
htt
cullmann added a comment.
Looks reasonable + test case, nice.
Btw., would it be possible to remove the last remaining hard coded color
here, too?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21508
To: jpoelen, #framework_syntax_highlighting, dhauma
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
- fix `x=`: is a rule named `x=`, not a variable
- fix `exe onx`: is a rule call
