D20238: device: include Reapply() in the interface

2019-04-03 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > device.h:241 > + */ > +QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, > qulonglong version_id, uint flags); > /** 1. const NMVariantMapMap &connection 2. I would maybe pick a different name, because it doesn't rea

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado
aleksanderm updated this revision to Diff 55379. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20238?vs=55377&id=55379 REVISION DETAIL https://phabricator.kde.org/D20238 AFFECTED FILES src/device.cpp src/device.h To: aleksanderm, jgrulich, #f

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: jgrulich, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY The NetworkMan