astippich added a comment.
windows build fails
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20133
To: bruns, #baloo, #frameworks, #windows, #freebsd, ngrah
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1e3f84f00620: [UserMetaData] Untangle Windows,
Linux/BSD/Mac and stub code. (authored by bruns).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20133?vs=55088
astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.
Still kind of hard to read, especially on phabricator. Anyway, a definite
improvement.
Untested on anything besides linux
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION
bruns added a comment.
I don' t think there is gained much by splitting it, and as you said, there
are also drawbacks ...
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20133
To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: adridg, k
adridg added a comment.
I'd start to think about three separate files , unix_impl.cpp,
windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues,
probably, when only one of them is updated).
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20133
bruns added a comment.
Ping!
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20133
To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abr
bruns added a dependent revision: D20136: [UserMetaData] Handle changes in
attribute data size correctly.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20133
To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: kde-frameworks-devel, gennad,
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, Windows, FreeBSD, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
The Windows code only shares the funct
