D19696: Add blender thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R373:2da545defff9: Add blender thumbnailer (authored by chinmoyr). REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53971&id=54065 REVISION DETAIL h

D19696: Add blender thumbnailer

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R373 Image Thumbnailers BRANCH master REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks, bruns Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexd

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53971. chinmoyr added a comment. Removed unused headers. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53848&id=53971 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19696 AFFECTE

D19696: Add blender thumbnailer

bruns added a comment. Save the two nitpicks, looks good to me now. Anyone else any comments? INLINE COMMENTS > blendercreator.cpp:24 > +#include > +#include > + Really required? > blendercreator.cpp:29 > +#include > +#include > +#include Unused ... REPOSITORY R373 Image Thumb

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53848. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Issues fixed. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53820&id=53848 BRANCH master REVISION DETAIL https://ph

D19696: Add blender thumbnailer

chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:134 > So does the code I linked to. No need to cook your own. Ah, sorry. I misunderstood what was written in doc. It really does swap them. REPOSITORY R373 Image Thumbnailers REVISION DETAIL https://phabric

D19696: Add blender thumbnailer

bruns added inline comments. INLINE COMMENTS > blendercreator.cpp:67 > +QPointer gzFile; > +if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip > member starts with ID1(0x1f) and ID2(0x8b)) > +file.close(); This requires a comment, stating gzip compression is opti

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53820. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Moved to kdegraphics-thumbnailer Got rid of operator>>() and fixed other issues. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D19696: Add blender thumbnailer

chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:57 > I think this is already done by the calling code - the thumbnailer gets only > called when the mimetype matches. This part is required because blender can save files with gzip compression. Examples here :

D19696: Add blender thumbnailer

bruns added inline comments. INLINE COMMENTS > blendercreator.cpp:134 > +blendStream.readRawData(imgBuffer, length); > +abgr_to_argb(imgBuffer, length); > +QImage thumbnail((unsigned char*)imgBuffer, x, y, QImage::Format_ARGB32); https://doc.qt.io/qt-5/qimage.html#rgbSwapped-1 REPOS

D19696: Add blender thumbnailer

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > blendercreator.cpp:57 > +QPointer gzFile; > +if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip > member starts with ID1(0x1f) and ID2(0

D19696: Add blender thumbnailer

ngraham added a comment. What would make sense to me is to have a single repo/package that holds all thumbnailers (`kde-thumbnailers`?). Having them in multiple repos/packages doesn't make sense because there's no real reason to want to only exclude certain thumbnailers in the packaging, and

D19696: Add blender thumbnailer

ltoscano added a comment. In D19696#429476 , @broulik wrote: > Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbna

D19696: Add blender thumbnailer

broulik added a comment. Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbnailers a thing that is installed out of the box in most distros? REPOSITORY R320 KI

D19696: Add blender thumbnailer

ltoscano added a comment. I have my usual question: shouldn't this go into kdegraphics-thumbnailers? kio-extras shouldn't be a "dump everything which is not somewhere else". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc: ltosc

D19696: Add blender thumbnailer

chinmoyr edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mike

D19696: Add blender thumbnailer

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This extracts thumbnail from .blend files. Before: Defau