loh.tar abandoned this revision.
loh.tar added a comment.
To relieve the maintainer it's droped now.
But I still have the feeling there could be something improved at these
"Read-Only Stuff"
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19511
To: loh.tar, #kt
cullmann added a comment.
I still think we should stay with status quo, can you drop this request?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19511
To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,
g
cullmann added a comment.
I actually would just keep the status quo here ;=)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19511
To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,
gennad, domson, michael
loh.tar added a comment.
So, then I assume you would be pro this patch.
I notice one behavior that would be against this patch but not pro the
meaning of "Read Only Mode". When you set this setting and issue a save request
you get the "Save as" dialog. Such behavior is good in any case.
ngraham added a comment.
In general I don't think it makes sense to be able to mark an
already-modified-but-not-yet-saved document as read-only. It's already been
written to!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19511
To: loh.tar, #ktexteditor, cullma
loh.tar added a comment.
@ngraham Nate? Your opinion to the question?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19511
To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,
gennad, domson, michaelh, brun
loh.tar added a subscriber: ngraham.
loh.tar added a comment.
There is some reason why I came to this idea. ATM is that thought not so
sharp present :-/
But it was related to the auto-reload patch and the lock icon in the bar.
@ngraham what do you think in general? Make a read only sett
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Thought about it bit more, actually like the "I can save even thought not
modified" I think the "I can set read-only thought modified" is ok and actually
no bug but a feature.
cullmann added a comment.
Hmm, two things:
1. implementation wise: don't we have a problem here that the
connect(document(), &KTextEditor::DocumentPrivate::modifiedChanged, [=] {
m_toggleWriteLock->setEnabled(!doc()->isModified()); }); will not be
unconnected if the view dies and we cal
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
It's somehow pointless to activate the read-only mode when the
10 matches
Mail list logo
