D19453: Fix repository deletion warning

2019-03-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:29e081b94b84: Fix repository deletion warning (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19453?vs=52919&id=52943 REVISION DE

D19453: Fix repository deletion warning

2019-03-01 Thread Dominik Haumann
dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D19453 To: vkrause, cullmann, dhaumann Cc: kossebau, cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D19453: Fix repository deletion warning

2019-03-01 Thread Friedrich W. H. Kossebau
kossebau added a comment. I can confirm this results in the warnings about `Repository got deleted while a highlighter is still active!` no longer being shown when using D19432 . Also no issues seen in Kate. But not enough understanding of this co

D19453: Fix repository deletion warning

2019-03-01 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good catch :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D19453 To: vkrause, cullmann Cc: cullmann, kwrite-devel, kde-framewor

D19453: Fix repository deletion warning

2019-03-01 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Since 6166da75 the inval