D19298: Make it compile without foreach

2019-03-22 Thread Kurt Hindenburg
hindenburg added a comment. On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine. Undefin

D19298: Make it compile without foreach

2019-03-21 Thread Kurt Hindenburg
hindenburg added a comment. FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D19298 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks

D19298: Make it compile without foreach

2019-03-03 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R283:cd7490e85008: Make it compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19298?vs=52526&id=53097#toc REPOSITORY R283 KAuth CHANGES SINCE LAST UPD

D19298: Make it compile without foreach

2019-03-02 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Polkit1Backend.cpp:203 > { > -Q_FOREACH (const QString &action, m_cachedResults.keys()) { > +const auto listKeys = m_cachedResults.keys(); > +for (const QSt

D19298: Make it compile without foreach

2019-02-25 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R283 KAuth BRANCH compile_without_foreach