D19016: Update Android toolchain files to reality

2019-02-26 Thread Johnny Jazeix
jjazeix added a comment. In D19016#420246 , @apol wrote: > Applications can still override it, note it's a default. > Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk Ok, good for me :). Than

D19016: Update Android toolchain files to reality

2019-02-26 Thread Aleix Pol Gonzalez
apol added a comment. Applications can still override it, note it's a default. Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19016 To: vkrause, apol Cc: jjazei

D19016: Update Android toolchain files to reality

2019-02-25 Thread Johnny Jazeix
jjazeix added inline comments. INLINE COMMENTS > Android.cmake:150 > set_deprecated_variable(CMAKE_ANDROID_ARCH_ABI ANDROID_ABI "armeabi-v7a") > -set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "14") > +set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "21") > Sorry, I'm

D19016: Update Android toolchain files to reality

2019-02-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:81374904954b: Update Android toolchain files to reality (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19016?vs=51701&id=51749 R

D19016: Update Android toolchain files to reality

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19016 To: vkrause, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh,

D19016: Update Android toolchain files to reality

2019-02-14 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - NDK r18 does not ship GCC anymore, it's only clang now - same for STL, there's only lib