This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:eda235463cd2: Avoid duplicate *-php.xml files in
"data/CMakeLists.txt" (authored by cullmann).
REPOSITORY
R216 Synta
nibags accepted this revision.
nibags added a comment.
It's good, I think it's a better solution ;D
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18746
To: cullmann, #framework_syntax_highlighting, dhaumann, nibags
Cc: kwrite-devel, kde-frameworks-devel
cullmann updated this revision to Diff 51542.
cullmann added a comment.
I would propose this, OK for you?
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18746?vs=50913&id=51542
REVISION DETAIL
https://phabricator.kde.org/D18746
AFFECTED FILE
cullmann commandeered this revision.
cullmann edited reviewers, added: nibags; removed: cullmann.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18746
To: cullmann, #framework_syntax_highlighting, dhaumann, nibags
Cc: kwrite-devel, kde-frameworks-devel, genn
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hmm, is source == binary directory allowed at all?
I would prefer to generate the files into a different directory, e.g.
${CMAKE_CURRENT_BINARY_DIR}/syntax/generated, that wo
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
When `CMAKE_CURRENT_SOURCE_D
