This revision was automatically updated to reflect the committed changes.
Closed by commit R294:d29a5d644913: Replace KIconThemes dependency with
equivalent QIcon usage (authored by vkrause).
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18731?vs=50870&id=
cfeck accepted this revision.
cfeck added a comment.
But KDE also supports
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18731
To: vkrause, davidedmundson, cfeck
Cc: broulik, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
vkrause added a comment.
Tested Konqueror bookmarks. New bookmarks don't seem to get the favicon set
until you explicitly trigger the "Update Favicon" action, afterwards they have
it and it remains across restarts. So this seems to work as expected.
Regarding the indirect dependencies, yes,
broulik added a comment.
I think `QIcon::fromTheme` also handles absolute paths, if given. This should
be fine.
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18731
To: vkrause, davidedmundson
Cc: broulik, cfeck, kde-frameworks-devel, michaelh,
cfeck added a comment.
Are application-specific icons now accessible with QIcon::fromTheme? Think
Konqueror favicons in bookmark menu.
Also, according to
https://api.kde.org/frameworks/kbookmarks/html/kbookmarks-dependencies.html
KBookmarks indirectly depends on KIconThemes via KTextWid
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18731
To: vkrause, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18731
AFFECTED FILES
CMakeLists.txt
src/
