sirgienko closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18714
To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh,
genethomas, ngraham, bruns, demsking, c
dhaumann added a comment.
In your branch, you should type: `arc land`
This will merge your branch to master and commit/push your changes, and close
this revision. This only works, if you have commit access. If not, we'll take
care of this for now.
REPOSITORY
R216 Syntax Highlighting
BRA
sirgienko added a comment.
Should I land it via arc? Or mannualy commit it (for short commit message)?
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18714
To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-deve
sirgienko updated this revision to Diff 50809.
sirgienko added a comment.
Increase version
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18714?vs=50807&id=50809
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18714
AFFECTED FI
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me, the only missing part is to increase thw "version" number
each time a highlighting file is changed.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DE
sirgienko retitled this revision from "Add some Maxima constans to
MaximaVariable list" to "Add some Maxima constans and function".
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18714
To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-fram
