D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dda4edcc6eb0: [breeze desktop theme/dialogs] Add rounded corners to dialogs (authored by rooty). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. Okay seeing as I'm seeing this corner problem with my icons as well, F6589150: image.png vs F6589155: image.png I think it's safe to land this. Also it's way past Saturday so :D REPOSITOR

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#403154 , @zzag wrote: > The blur effect is able to handle rounded corners, a client just has to upload proper blur region. Yes, I had the latest version of the diff. I don't use the zoom effect. I think y

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. The blur effect is able to handle rounded corners, a client just has to upload proper blur region. Yes, I had the latest version of the diff. I don't use the zoom effect. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricato

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. By the way guys, it does look sometimes better with the blur off: F6580935: image.png (and with the blur on, the corners behave weird F6580938: image.png , see bottom left corner) May

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#403143 , @davidedmundson wrote: > Wait a few days. Frameworks tagging is the first Saturday of the month. > > We want some wider testing given this hits stable releases. Not a bad idea. Next week then

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. Nate, thank you for accepting the patch! Okay so the corner thing - that bug actually happens //everywhere.// **All of the following screenshots are of master, not this patch.** For example, Breeze Dark, Background Contrast on, Blur off F6580832: fook-definit

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

davidedmundson added a comment. Wait a few days. Frameworks tagging is the first Saturday of the month. We want some wider testing given this hits stable releases. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18545 To: root

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. ... though I'm not sure whether that's a bug. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. Well, there are still issues with corners F6580225: Screenshot_20190131_151157.png (both the blur and the background contrast effect are disabled) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DET

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works as intended for me on both Breeze and Breeze Dark and looks fantastic. Sooo... is there anything left to do here, or shall we land it? REPOSITORY R242 Plasma Framework (Libra

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#402668 , @zzag wrote: > Shot in the dark: maybe purge cache? No change unfortunately. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ng

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. In D18545#402636 , @ngraham wrote: > It there indeed a bug in the KWin effect somewhere? I don't think so. Both the blur and the background contrast effect operate on regions. Rounded corners are approximated by a bu

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#402636 , @ngraham wrote: > So this is now working for me as intended, yay! The effect is very strongly positive. Huge improvement IMO. > > But do we know why? It there indeed a bug in the KWin effect somewhere

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

ngraham added a comment. So this is now working for me as intended, yay! The effect is very strongly positive. Huge improvement IMO. But do we know why? It there indeed a bug in the KWin effect somewhere? Or was the SVG previously broken somehow? Or was the prior corner radius too small

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty retitled this revision from "[breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs" to "[breeze desktop theme/dialogs] Add rounded corners to dialogs". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham