D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:871dd742651b: Improve contrast of preferences-system-time (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D184

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-framework

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread TrickyRicky
trickyricky26 updated this revision to Diff 50007. trickyricky26 added a comment. - Make the outline a solid circle behind the black on to avoid weird aliasing issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18432?vs=50003&id=50007 BRANCH fix

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me! Other #VDG folks, shall we land this? REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REV

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.