D18345: Fix python binding generation for classes with deleted copy constructors

2019-01-18 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R240:a2a404f9f924: Fix python binding generation for classes with deleted copy constructors (authored by aacid). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D18345: Fix python binding generation for classes with deleted copy constructors

2019-01-18 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code... REPOSITORY R240 Extra CMake Mod

D18345: Fix python binding generation for classes with deleted copy constructors

2019-01-18 Thread Christophe Giboudeaux
cgiboudeaux added a reviewer: lbeltrame. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18345 To: aacid, lbeltrame Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

2019-01-17 Thread Albert Astals Cid
aacid added subscribers: skelly, cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18345 To: aacid Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

2019-01-17 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. aacid requested review of this revision. TEST PLAN kcoreaddons compiles again REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL