This revision was automatically updated to reflect the committed changes.
Closed by commit R236:1449db57aa67: KRatingPainter: Delete copy constructor and
assignment operator (authored by aacid).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18138?vs=49
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Right.
If someone would copy the object using the default implementations, they
would only get two instances pointing to the same Private.
REPOSITORY
R236 KWidgetsAddons
BRANCH
mast
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.
